pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart - Issue 1377623002: Report a fatal error on attempt to rename an element declared in SDK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart

Issue 1377623002: Report a fatal error on attempt to rename an element declared in SDK. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart ('k') | pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart

diff --git a/pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart b/pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart

index 03b1693e12fc4563c98ad6919964c758da86d287..2bc8dc0548f3c1e9131e42a8b9aec2eb577c7294 100644

--- a/pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart

+++ b/pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart

@@ -55,6 +55,21 @@ class A {

expectedContextSearch: 'newName() {} // existing');

}

+ test_checkInitialConditions_inSDK() async {

+ indexTestUnit('''

+main() {

+ new String.fromCharCodes([]);

+''');

+ createRenameRefactoringAtString('fromCharCodes(');

+ // check status

+ refactoring.newName = 'newName';

+ RefactoringStatus status = await refactoring.checkInitialConditions();

+ assertRefactoringStatus(status, RefactoringProblemSeverity.FATAL,

+ expectedMessage:

+ "The constructor 'String.fromCharCodes' is defined in the SDK, so cannot be renamed.");

+ }

test_checkNewName() {

indexTestUnit('''

class A {