pkg/analysis_server/lib/src/services/refactoring/rename.dart - Issue 1377623002: Report a fatal error on attempt to rename an element declared in SDK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename.dart

Issue 1377623002: Report a fatal error on attempt to rename an element declared in SDK. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/util.dart ('k') | pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename.dart b/pkg/analysis_server/lib/src/services/refactoring/rename.dart

index b22d74d360a491c395cdb0eb5c3b0987b8283fdc..bd975270c773e85aa48662ed8160af4e01639d15 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename.dart

@@ -9,11 +9,13 @@ import 'dart:async';

import 'package:analysis_server/src/protocol_server.dart' hide Element;

import 'package:analysis_server/src/services/correction/source_range.dart';

import 'package:analysis_server/src/services/correction/status.dart';

+import 'package:analysis_server/src/services/correction/util.dart';

import 'package:analysis_server/src/services/refactoring/refactoring.dart';

import 'package:analysis_server/src/services/refactoring/refactoring_internal.dart';

import 'package:analysis_server/src/services/search/search_engine.dart';

import 'package:analyzer/src/generated/element.dart';

import 'package:analyzer/src/generated/engine.dart';

+import 'package:analyzer/src/generated/java_core.dart';

import 'package:analyzer/src/generated/source.dart';

/**

@@ -136,6 +138,13 @@ abstract class RenameRefactoringImpl extends RefactoringImpl

@override

Future<RefactoringStatus> checkInitialConditions() {

RefactoringStatus result = new RefactoringStatus();

+ if (element.source.isInSystemLibrary) {

+ String message = format(

+ "The {0} '{1}' is defined in the SDK, so cannot be renamed.",

+ getElementKindName(element),

+ getElementQualifiedName(element));

+ result.addFatalError(message);

+ }

return new Future.value(result);

}