Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: pkg/analyzer/test/src/task/dart_work_manager_test.dart

Issue 1377613002: Fix for the libraries to parts map. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/task/dart_work_manager.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/dart_work_manager_test.dart
diff --git a/pkg/analyzer/test/src/task/dart_work_manager_test.dart b/pkg/analyzer/test/src/task/dart_work_manager_test.dart
index d8b9cae4593ea6e3b27e88176075780959e0e94e..e15aa7b4ef85d8cf1f81e208e43589903bbf3685 100644
--- a/pkg/analyzer/test/src/task/dart_work_manager_test.dart
+++ b/pkg/analyzer/test/src/task/dart_work_manager_test.dart
@@ -576,9 +576,14 @@ class DartWorkManagerTest {
Source library2 = new TestSource('library2.dart');
_getOrCreateEntry(part1).setValue(CONTAINING_LIBRARIES, [], []);
expect(cache.getState(part1, CONTAINING_LIBRARIES), CacheState.VALID);
+ // configure AnalysisContext mock
+ when(context.prioritySources).thenReturn(<Source>[]);
+ when(context.shouldErrorsBeAnalyzed(anyObject, anyObject))
+ .thenReturn(false);
// library1 parts
manager.resultsComputed(library1, {
- INCLUDED_PARTS: [part1, part2]
+ INCLUDED_PARTS: [part1, part2],
+ SOURCE_KIND: SourceKind.LIBRARY
});
expect(manager.partLibrariesMap[part1], [library1]);
expect(manager.partLibrariesMap[part2], [library1]);
@@ -587,7 +592,8 @@ class DartWorkManagerTest {
expect(manager.libraryPartsMap[library2], isNull);
// library2 parts
manager.resultsComputed(library2, {
- INCLUDED_PARTS: [part2, part3]
+ INCLUDED_PARTS: [part2, part3],
+ SOURCE_KIND: SourceKind.LIBRARY
});
expect(manager.partLibrariesMap[part1], [library1]);
expect(manager.partLibrariesMap[part2], [library1, library2]);
@@ -681,6 +687,15 @@ class DartWorkManagerTest {
expect_unknownSourceQueue([source1, source3]);
}
+ void test_resultsComputed_updatePartsLibraries_partParsed() {
+ Source part = new TestSource('part.dart');
+ expect(manager.libraryPartsMap, isEmpty);
+ // part.dart parsed, no changes is the map of libraries
+ manager.resultsComputed(
+ part, {SOURCE_KIND: SourceKind.PART, INCLUDED_PARTS: <Source>[]});
+ expect(manager.libraryPartsMap, isEmpty);
+ }
+
CacheEntry _getOrCreateEntry(Source source) {
CacheEntry entry = cache.get(source);
if (entry == null) {
« no previous file with comments | « pkg/analyzer/lib/src/task/dart_work_manager.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698