Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1377603006: [es6] Function constructor-created functions should be named "anonymous" (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Function constructor-created functions should be named "anonymous" Besides matching the spec, this matches the behavior of Firefox and Edge. BUG=v8:3699 LOG=n CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/51d28914bdfbaaf9299bb7b375c48a62163262e5 Cr-Commit-Position: refs/heads/master@{#31030}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/accessors.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
adamk
mstarzinger added to review for heap/OWNERS.
5 years, 2 months ago (2015-09-30 00:14:51 UTC) #2
adamk
This is clearly trivial (and low priority), I just happened to be poking at test262.status ...
5 years, 2 months ago (2015-09-30 00:19:43 UTC) #3
Michael Starzinger
LGTM.
5 years, 2 months ago (2015-09-30 07:57:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377603006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377603006/20001
5 years, 2 months ago (2015-09-30 17:18:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compile_rel/builds/5304)
5 years, 2 months ago (2015-09-30 17:23:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377603006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377603006/20001
5 years, 2 months ago (2015-09-30 19:10:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-30 19:20:01 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 19:20:16 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/51d28914bdfbaaf9299bb7b375c48a62163262e5
Cr-Commit-Position: refs/heads/master@{#31030}

Powered by Google App Engine
This is Rietveld 408576698