Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1377553002: Update default browser infobar for MD (Closed)

Created:
5 years, 2 months ago by Evan Stade
Modified:
5 years, 2 months ago
Reviewers:
Peter Kasting, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update default browser infobar for MD Also tweak the color and size of the icon to better match mocks. The previous size of 16 was based on the geolocation icon, which has been confirmed as erroneously large (something we should address separately). Also change the type of the infobar to normal from warning (this affects MD and pre-MD). BUG=520266 TBR=sky@chromium.org Committed: https://crrev.com/9513208dda6d8e9f355f622165c17432b87a9f3e Cr-Commit-Position: refs/heads/master@{#351354}

Patch Set 1 #

Patch Set 2 : change to normal type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -4 lines) Patch
M chrome/browser/ui/startup/default_browser_prompt.cc View 1 3 chunks +16 lines, -1 line 0 comments Download
M components/infobars/core/infobar_delegate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gfx/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
A ui/gfx/vector_icons/chrome_product.icon View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Evan Stade
5 years, 2 months ago (2015-09-28 19:20:33 UTC) #2
Peter Kasting
LGTM
5 years, 2 months ago (2015-09-28 22:56:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377553002/20001
5 years, 2 months ago (2015-09-28 23:06:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/104494)
5 years, 2 months ago (2015-09-28 23:21:03 UTC) #7
Evan Stade
+sky TBR for ui/gfx/BUILD.gn
5 years, 2 months ago (2015-09-29 17:43:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377553002/20001
5 years, 2 months ago (2015-09-29 17:45:00 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-29 18:11:50 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 18:13:06 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9513208dda6d8e9f355f622165c17432b87a9f3e
Cr-Commit-Position: refs/heads/master@{#351354}

Powered by Google App Engine
This is Rietveld 408576698