Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1377533002: Flip Google Chrome Linux x64 bot from GYP to GN. (Closed)

Created:
5 years, 2 months ago by Dirk Pranke
Modified:
5 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_linux_perf_to_gn
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip Google Chrome Linux x64 bot from GYP to GN. This is on the chromium.chrome waterfall. R=brettw@chromium.org BUG=432959 Committed: https://crrev.com/05ae5552d40ed73a8b7c1e9222caa30806682f73 Cr-Commit-Position: refs/heads/master@{#351222}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/mb/mb_config.pyl View 3 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (1 generated)
Dirk Pranke
5 years, 2 months ago (2015-09-28 19:05:39 UTC) #1
brettw
lgtm
5 years, 2 months ago (2015-09-28 19:50:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377533002/1
5 years, 2 months ago (2015-09-28 21:59:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 01:11:04 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/05ae5552d40ed73a8b7c1e9222caa30806682f73 Cr-Commit-Position: refs/heads/master@{#351222}
5 years, 2 months ago (2015-09-29 01:12:30 UTC) #6
yoichio
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1372323003/ by yoichio@chromium.org. ...
5 years, 2 months ago (2015-09-29 01:46:46 UTC) #7
Dirk Pranke
On 2015/09/29 01:46:46, yoichio wrote: > A revert of this CL (patchset #1 id:1) has ...
5 years, 2 months ago (2015-09-29 02:15:46 UTC) #8
brettw
5 years, 2 months ago (2015-09-29 02:52:47 UTC) #9
Message was sent while issue was closed.
Looks like we just need a forwarding target so that things have the same name.

Powered by Google App Engine
This is Rietveld 408576698