Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: chrome/browser/extensions/extension_system_factory.h

Issue 137753016: ExtensionSystem cleanup part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: deps Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_system_factory.h
diff --git a/chrome/browser/extensions/extension_system_factory.h b/chrome/browser/extensions/extension_system_factory.h
index f2f8e7b8942cc1967543626d4f34aa1a37028b36..673976d71ab3cf9064e58a158ce49b43a210d497 100644
--- a/chrome/browser/extensions/extension_system_factory.h
+++ b/chrome/browser/extensions/extension_system_factory.h
@@ -8,7 +8,7 @@
#include "base/memory/singleton.h"
#include "chrome/browser/extensions/extension_system_impl.h"
#include "components/browser_context_keyed_service/browser_context_keyed_service_factory.h"
-#include "extensions/browser/extension_system.h"
+#include "extensions/browser/extension_system_provider.h"
class BrowserContextKeyedService;
@@ -37,11 +37,12 @@ class ExtensionSystemSharedFactory : public BrowserContextKeyedServiceFactory {
content::BrowserContext* context) const OVERRIDE;
};
-// BrowserContextKeyedServiceFactory for ExtensionSystem.
-class ExtensionSystemFactory : public BrowserContextKeyedServiceFactory {
+// BrowserContextKeyedServiceFactory for ExtensionSystemImpl.
+// TODO(yoz): Rename to ExtensionSystemImplFactory.
+class ExtensionSystemFactory : public ExtensionSystemProvider {
public:
- static ExtensionSystem* GetForBrowserContext(
- content::BrowserContext* context);
+ virtual ExtensionSystem* GetForBrowserContext(
James Cook 2014/02/12 17:18:12 nit: comment which interface you are overriding
Yoyo Zhou 2014/02/12 23:32:10 Done.
+ content::BrowserContext* context) OVERRIDE;
static ExtensionSystemFactory* GetInstance();

Powered by Google App Engine
This is Rietveld 408576698