Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 137753007: Adding number of users to crash record (Closed)

Created:
6 years, 11 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Adding number of users to ChromeOS crash record BUG=330217 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245408

Patch Set 1 #

Patch Set 2 : Re-upload same patch #

Total comments: 6

Patch Set 3 : Addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M chrome/browser/chromeos/login/user_manager_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 6 chunks +9 lines, -0 lines 0 comments Download
M chrome/common/crash_keys.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Mr4D (OOO till 08-26)
Please have a look!
6 years, 11 months ago (2014-01-16 15:21:00 UTC) #1
Robert Sesek
Can you reupload? Rietveld complains of chunk mismatch.
6 years, 11 months ago (2014-01-16 15:34:07 UTC) #2
Mr4D (OOO till 08-26)
Very odd. I didn't get any error message when uploading the patch, so I didn't ...
6 years, 11 months ago (2014-01-16 16:34:17 UTC) #3
Dmitry Polukhin
lgtm
6 years, 11 months ago (2014-01-16 17:17:15 UTC) #4
Robert Sesek
On 2014/01/16 16:34:17, Mr4D wrote: > Very odd. I didn't get any error message when ...
6 years, 11 months ago (2014-01-16 17:26:00 UTC) #5
Mr4D (OOO till 08-26)
Addressed. Please have another look! https://codereview.chromium.org/137753007/diff/270001/chrome/common/crash_keys.cc File chrome/common/crash_keys.cc (right): https://codereview.chromium.org/137753007/diff/270001/chrome/common/crash_keys.cc#newcode67 chrome/common/crash_keys.cc:67: #if defined(OS_CHROMEOS) On 2014/01/16 ...
6 years, 11 months ago (2014-01-16 17:51:02 UTC) #6
Robert Sesek
lgtm
6 years, 11 months ago (2014-01-16 17:52:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/137753007/380001
6 years, 11 months ago (2014-01-16 17:55:16 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247430
6 years, 11 months ago (2014-01-16 23:01:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/137753007/380001
6 years, 11 months ago (2014-01-16 23:06:54 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 01:34:46 UTC) #11
Message was sent while issue was closed.
Change committed as 245408

Powered by Google App Engine
This is Rietveld 408576698