Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 137753002: Changed sync-internals search to a submit instead of incremental (Closed)

Created:
6 years, 11 months ago by mferreria
Modified:
6 years, 10 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Changed sync-internals search to a submit instead of incremental The change was needed because when there was a lot of information to be displayed, and a if the query was not pasted, then the incremental search took too long and the partial results rendering was unnecesarily refreshing the results pane when what was actually needed was just the full query. BUG=333414 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/resources/sync_internals/search.html View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/sync_internals/search.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/sync_internals/sync_search.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/sync_internals/sync_search.js View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mferreria_g
Changed the search pane of special page sync-internals to be submit-driven rather than incremental search. ...
6 years, 11 months ago (2014-01-14 02:24:36 UTC) #1
rlarocque
nit: I prefer the commit message to follow the convention of a 52 column header, ...
6 years, 11 months ago (2014-01-14 19:00:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mferreria@google.com/137753002/1
6 years, 11 months ago (2014-01-14 19:32:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mferreria@google.com/137753002/1
6 years, 11 months ago (2014-01-14 23:38:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mferreria@google.com/137753002/1
6 years, 11 months ago (2014-01-15 04:22:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mferreria@google.com/137753002/1
6 years, 11 months ago (2014-01-15 18:49:26 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 04:21:52 UTC) #7
Message was sent while issue was closed.
Change committed as 245104

Powered by Google App Engine
This is Rietveld 408576698