Issue 1377523007: dart2js: Don't use "void" as field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1377523007: dart2js: Don't use "void" as field. (Closed)

Created:
5 years, 2 months ago by floitsch

Modified:
5 years, 2 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js: Don't use "void" as field. Although legal now, some engines don't like `void` as property name. R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/c2aa04db8b51ee812fe2361edf11da69261360d9

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/compiler/lib/src/js_backend/namer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

floitsch

On 2015/10/03 00:15:34, sra1 wrote: > LGTM. > > I'm curious where this showed up ...

5 years, 2 months ago (2015-10-05 10:50:10 UTC) #4

floitsch

5 years, 2 months ago (2015-10-05 10:50:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c2aa04db8b51ee812fe2361edf11da69261360d9 (presubmit successful).