Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1377523003: PDF: Properly apply the CropBox to the MediaBox. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Properly apply the CropBox to the MediaBox. Otherwise funky things happen when the CropBox is bigger than the MediaBox. BUG=536630 TEST=manual, see bug Committed: https://crrev.com/601b7fba7533687975cf16882d3ba38964ef4e46 Cr-Commit-Position: refs/heads/master@{#351729}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -21 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 3 chunks +44 lines, -21 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
For reference, the bounding boxes are well documented. Just search for: CropBox MediaBox
5 years, 2 months ago (2015-09-29 22:16:08 UTC) #2
raymes
lgtm https://codereview.chromium.org/1377523003/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/1377523003/diff/1/pdf/pdfium/pdfium_engine.cc#newcode353 pdf/pdfium/pdfium_engine.cc:353: // Remember with PDFs, origin is bottom-left. nit: ...
5 years, 2 months ago (2015-10-01 04:19:48 UTC) #3
Lei Zhang
https://codereview.chromium.org/1377523003/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/1377523003/diff/1/pdf/pdfium/pdfium_engine.cc#newcode353 pdf/pdfium/pdfium_engine.cc:353: // Remember with PDFs, origin is bottom-left. On 2015/10/01 ...
5 years, 2 months ago (2015-10-01 04:50:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377523003/1
5 years, 2 months ago (2015-10-01 04:50:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 05:26:06 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 05:27:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/601b7fba7533687975cf16882d3ba38964ef4e46
Cr-Commit-Position: refs/heads/master@{#351729}

Powered by Google App Engine
This is Rietveld 408576698