Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1377523002: Add suppressions for persistent FYI failures (Closed)

Created:
5 years, 2 months ago by ccameron
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add suppressions for persistent FYI failures BUG=536887 Committed: https://crrev.com/b07a99f3714d65b0784e15a8d8b36676daea6b52 Cr-Commit-Position: refs/heads/master@{#351140}

Patch Set 1 #

Patch Set 2 : Limit to intel #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 2 chunks +41 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (4 generated)
ccameron
5 years, 2 months ago (2015-09-28 18:35:01 UTC) #2
bajones
LGTM
5 years, 2 months ago (2015-09-28 18:36:57 UTC) #3
ccameron
Thanks! https://codereview.chromium.org/1377523002/diff/20001/content/test/gpu/gpu_tests/webgl_conformance_expectations.py File content/test/gpu/gpu_tests/webgl_conformance_expectations.py (right): https://codereview.chromium.org/1377523002/diff/20001/content/test/gpu/gpu_tests/webgl_conformance_expectations.py#newcode674 content/test/gpu/gpu_tests/webgl_conformance_expectations.py:674: bug=536887) Added limitation to intel. https://codereview.chromium.org/1377523002/diff/20001/content/test/gpu/gpu_tests/webgl_conformance_expectations.py#newcode700 content/test/gpu/gpu_tests/webgl_conformance_expectations.py:700: bug=536887) ...
5 years, 2 months ago (2015-09-28 18:54:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377523002/20001
5 years, 2 months ago (2015-09-28 19:41:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 20:57:10 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b07a99f3714d65b0784e15a8d8b36676daea6b52 Cr-Commit-Position: refs/heads/master@{#351140}
5 years, 2 months ago (2015-09-28 20:58:50 UTC) #9
Ken Russell (switch to Gerrit)
5 years, 2 months ago (2015-09-28 22:06:23 UTC) #11
Message was sent while issue was closed.
Thanks for suppressing these. LGTM after the fact.

Powered by Google App Engine
This is Rietveld 408576698