Issue 13775006: Fixed web workers in Files.app v2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13775006: Fixed web workers in Files.app v2. (Closed)

Created:
7 years, 8 months ago by mtomasz

Modified:
7 years, 8 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed web workers in Files.app v2. Because of recent changes in the chrome infrastructure, importScripts started failing in packaged apps' web workers. This patch solves this issue by adding a web_accessible_resources entry, which makes it possible to load scripts via importScripts. TEST=Launch Files.app with --file-manager-packaged, check if thumbnails are being displayed. BUG=227512 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192805

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/resources/file_manager/manifest.json	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/resources/file_manager/manifest_new_ui.json	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/13775006/1

7 years, 8 months ago (2013-04-08 09:05:09 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 8 months ago (2013-04-08 09:13:28 UTC) #4

mtomasz

7 years, 8 months ago (2013-04-08 11:30:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r192805 (presubmit successful).

Expand Messages | Collapse Messages