SkImage::NewFromBitmap works with Index8

SkImage::NewFromBitmap works with Index8

BUG=skia:4390
Committed: https://skia.googlesource.com/skia/+/c56c6ef3ce6447f39894649d535acb1606595d31

[hal.canary, 2015-09-28 17:25:46]

Patchset #1 (id:1) has been deleted

[hal.canary, 2015-09-28 17:25:57]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-28 17:26:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377473002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377473002/20001

[hal.canary, 2015-09-28 17:27:33]

halcanary@google.com changed reviewers:
+ reed@google.com

[hal.canary, 2015-09-28 17:27:34]

PTAL

[commit-bot: I haz the power, 2015-09-28 17:32:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 17:32:12]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2015-09-28 17:36:57]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[hal.canary, 2015-09-28 17:37:25]

fixed

[commit-bot: I haz the power, 2015-09-28 17:37:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377473002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377473002/40001

[commit-bot: I haz the power, 2015-09-28 17:43:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 17:43:35]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-09-28 18:08:55]

lgtm w/ nit about the test itself.

https://codereview.chromium.org/1377473002/diff/40001/tests/ImageTest.cpp
File tests/ImageTest.cpp (right):

https://codereview.chromium.org/1377473002/diff/40001/tests/ImageTest.cpp#new...
tests/ImageTest.cpp:353: SkPMColor pmColors[1] = {SkPremultiplyARGBInline(255,
255, 255, 255)};
No need to bring in colorpriv.h

can use SkPreMultiplyColor(SK_ColorWHITE)

or actually, give your test, you can just put a zero in that array for the
ctable.

[hal.canary, 2015-09-28 18:48:30]

On 2015/09/28 18:08:55, reed1 wrote:
> lgtm w/ nit about the test itself.
> 
> https://codereview.chromium.org/1377473002/diff/40001/tests/ImageTest.cpp
> File tests/ImageTest.cpp (right):
> 
>
https://codereview.chromium.org/1377473002/diff/40001/tests/ImageTest.cpp#new...
> tests/ImageTest.cpp:353: SkPMColor pmColors[1] = {SkPremultiplyARGBInline(255,
> 255, 255, 255)};
> No need to bring in colorpriv.h
> 
> can use SkPreMultiplyColor(SK_ColorWHITE)
> 
> or actually, give your test, you can just put a zero in that array for the
> ctable.

done

[hal.canary, 2015-09-28 18:48:36]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-09-28 18:48:37]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1377473002/#ps60001
(title: "2015-09-28 (Monday) 14:48:00 EDT")

[commit-bot: I haz the power, 2015-09-28 18:49:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1377473002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1377473002/60001

[commit-bot: I haz the power, 2015-09-28 18:55:32]

Committed patchset #3 (id:60001) as
https://skia.googlesource.com/skia/+/c56c6ef3ce6447f39894649d535acb1606595d31