Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1377453007: bluetooth: Keep GATT connections open by retaining BluetoothGattConnection objects. (Closed)

Created:
5 years, 2 months ago by scheib
Modified:
5 years, 2 months ago
Reviewers:
ortuno
CC:
asanka, benjhayden+dwatch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bt-thread-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Keep GATT connections open by retaining BluetoothGattConnection objects. R=ortuno@chromium.org BUG=484781 Committed: https://crrev.com/63d155b865a05b2681e21c72fb1c0789793d8473 Cr-Commit-Position: refs/heads/master@{#352692}

Patch Set 1 #

Total comments: 2

Patch Set 2 : clear in set_adapter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M content/browser/bluetooth/bluetooth_dispatcher_host.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/bluetooth/bluetooth_dispatcher_host.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1389553002 Patch 40001

Messages

Total messages: 8 (2 generated)
scheib
5 years, 2 months ago (2015-10-05 23:23:34 UTC) #1
ortuno
LGTM https://codereview.chromium.org/1377453007/diff/1/content/browser/bluetooth/bluetooth_dispatcher_host.h File content/browser/bluetooth/bluetooth_dispatcher_host.h (right): https://codereview.chromium.org/1377453007/diff/1/content/browser/bluetooth/bluetooth_dispatcher_host.h#newcode193 content/browser/bluetooth/bluetooth_dispatcher_host.h:193: ScopedVector<device::BluetoothGattConnection> connections_; Should we clean this when we ...
5 years, 2 months ago (2015-10-06 19:45:46 UTC) #2
scheib
https://codereview.chromium.org/1377453007/diff/1/content/browser/bluetooth/bluetooth_dispatcher_host.h File content/browser/bluetooth/bluetooth_dispatcher_host.h (right): https://codereview.chromium.org/1377453007/diff/1/content/browser/bluetooth/bluetooth_dispatcher_host.h#newcode193 content/browser/bluetooth/bluetooth_dispatcher_host.h:193: ScopedVector<device::BluetoothGattConnection> connections_; On 2015/10/06 19:45:46, ortuno wrote: > Should ...
5 years, 2 months ago (2015-10-06 20:30:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377453007/10001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377453007/10001
5 years, 2 months ago (2015-10-06 20:32:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:10001)
5 years, 2 months ago (2015-10-06 21:38:52 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 21:39:50 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/63d155b865a05b2681e21c72fb1c0789793d8473
Cr-Commit-Position: refs/heads/master@{#352692}

Powered by Google App Engine
This is Rietveld 408576698