Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 1377433002: Roll ffmpeg deps to disable broken AAC SBR SSE2 functions. (Closed)

Created:
5 years, 2 months ago by DaleCurtis
Modified:
5 years, 2 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll ffmpeg deps to disable broken AAC SBR SSE2 functions. BUG=536773, 536601 TEST=new regression test. TBR=chcunningham Committed: https://crrev.com/db657597f594ca30c12f1fc3ea90b75e9473e009 Cr-Commit-Position: refs/heads/master@{#351101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M media/ffmpeg/ffmpeg_regression_tests.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
DaleCurtis
5 years, 2 months ago (2015-09-28 17:09:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377433002/1
5 years, 2 months ago (2015-09-28 17:09:58 UTC) #3
chcunningham
lgtm Can you give me access to http://code.google.com/p/chromium/issues/detail?id=536773 Also, Will audio quality be noticeably worse ...
5 years, 2 months ago (2015-09-28 17:44:09 UTC) #4
chcunningham
Err... I already have access on that bug, I meant to ask for this one: ...
5 years, 2 months ago (2015-09-28 17:44:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 19:20:31 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/db657597f594ca30c12f1fc3ea90b75e9473e009 Cr-Commit-Position: refs/heads/master@{#351101}
5 years, 2 months ago (2015-09-28 19:22:34 UTC) #7
DaleCurtis
5 years, 2 months ago (2015-09-28 20:18:53 UTC) #8
Message was sent while issue was closed.
No, this just disables the SSE2 variants, the C versions are still there.

Powered by Google App Engine
This is Rietveld 408576698