Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.h

Issue 1377353002: Update poster code as per https://html.spec.whatwg.org/#show-poster-flag Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update "show poster" flag as per spec Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLVideoElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElement.h b/third_party/WebKit/Source/core/html/HTMLVideoElement.h
index 056e560e787dbdf00b450dcf6b7b23623ba79614..c8b2c0e99b79cc268fd86e22b11d427917ce5135 100644
--- a/third_party/WebKit/Source/core/html/HTMLVideoElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLVideoElement.h
@@ -71,7 +71,7 @@ public:
// Used by WebGL to do GPU-GPU textures copy if possible.
bool copyVideoTextureToPlatformTexture(WebGraphicsContext3D*, Platform3DObject texture, GLenum internalFormat, GLenum type, bool premultiplyAlpha, bool flipY);
- bool shouldDisplayPosterImage() const { return displayMode() == Poster; }
+ bool shouldDisplayPosterImage() const { return m_showPoster; }
bool hasAvailableVideoFrame() const;
@@ -99,10 +99,12 @@ private:
bool isURLAttribute(const Attribute&) const override;
const AtomicString imageSourceURL() const override;
- void updateDisplayState() override;
void didMoveToNewDocument(Document& oldDocument) override;
- void setDisplayMode(DisplayMode) override;
+ void setShowPoster(bool) override;
+ // This flag is used to control when the user agent is to show a
+ // poster frame for a video element instead of showing the video contents.
+ bool m_showPoster : 1;
OwnPtrWillBeMember<HTMLImageLoader> m_imageLoader;
AtomicString m_defaultPosterURL;
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLVideoElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698