third_party/WebKit/Source/core/html/HTMLVideoElement.h - Issue 1377353002: Update poster code as per https://html.spec.whatwg.org/#show-poster-flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.h

Issue 1377353002: Update poster code as per https://html.spec.whatwg.org/#show-poster-flag Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLVideoElement.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLVideoElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLVideoElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElement.h b/third_party/WebKit/Source/core/html/HTMLVideoElement.h

index 056e560e787dbdf00b450dcf6b7b23623ba79614..8bba6c058b5c297371e9852bc8296c3f7e8828ed 100644

--- a/third_party/WebKit/Source/core/html/HTMLVideoElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLVideoElement.h

@@ -71,7 +71,7 @@ public:

// Used by WebGL to do GPU-GPU textures copy if possible.

bool copyVideoTextureToPlatformTexture(WebGraphicsContext3D*, Platform3DObject texture, GLenum internalFormat, GLenum type, bool premultiplyAlpha, bool flipY);

- bool shouldDisplayPosterImage() const { return displayMode() == Poster; }

+ bool shouldDisplayPosterImage() const { return m_showPoster; }

bool hasAvailableVideoFrame() const;

@@ -99,10 +99,12 @@ private:

bool isURLAttribute(const Attribute&) const override;

const AtomicString imageSourceURL() const override;

- void updateDisplayState() override;

+ void updateDisplayState(bool forceUpdate) override;

void didMoveToNewDocument(Document& oldDocument) override;

- void setDisplayMode(DisplayMode) override;

+ void setShowPoster(bool) override;

+ // whether to show poster or video frame

+ bool m_showPoster : 1;

OwnPtrWillBeMember<HTMLImageLoader> m_imageLoader;

AtomicString m_defaultPosterURL;