Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: third_party/cld_2/BUILD.gn

Issue 1377333002: Make cld2_table_size configurable in GN builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move cld2_table_size declaration to third_party/cld_2/BUILD.gn Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/features.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/cld_2/BUILD.gn
diff --git a/third_party/cld_2/BUILD.gn b/third_party/cld_2/BUILD.gn
index bd3a181e5d7d33c17aede02de7795cd4dd2325c6..6d0e8babde6f50b74606459ef8159c94a91b47ef 100644
--- a/third_party/cld_2/BUILD.gn
+++ b/third_party/cld_2/BUILD.gn
@@ -4,6 +4,14 @@
import("//build/config/features.gni")
+declare_args() {
+ if (is_android || is_ios) {
+ cld2_table_size = 0 # Small, accurate tables
+ } else {
+ cld2_table_size = 2 # Larger, more accurate tables
+ }
+}
+
gypi_values = exec_script("//build/gypi_to_gn.py",
[ rebase_path("cld_2.gyp") ],
"scope",
@@ -31,8 +39,6 @@ gypi_values = exec_script("//build/gypi_to_gn.py",
# components/translate/content/renderer/renderer_cld_utils.cc
cld2_platform_support = "static"
-cld2_table_size = 2
-
config("cld2_data_warnings") {
visibility = [ ":*" ]
if (is_clang) {
« no previous file with comments | « build/config/features.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698