Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1508)

Issue 1377323003: dart2js cps: Status updates and minor fixes for host checked mode. (Closed)

Created:
5 years, 2 months ago by asgerf
Modified:
5 years, 2 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Status updates and minor fixes for host checked mode. CPS should now run the test suite cleanly in host-checked mode. Let's keep it that way. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/f1a40e23c19af7e92e4f9cb16819e4c33bde4ab1

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -4 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/pkg.status View 1 chunk +30 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 chunks +9 lines, -2 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 2 months ago (2015-10-02 13:23:39 UTC) #2
floitsch
LGTM.
5 years, 2 months ago (2015-10-02 13:25:09 UTC) #3
asgerf
5 years, 2 months ago (2015-10-02 13:36:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f1a40e23c19af7e92e4f9cb16819e4c33bde4ab1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698