Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 13773008: Adding WebRTC performance expectations. (Closed)

Created:
7 years, 8 months ago by phoglund_chromium
Modified:
7 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Adding WebRTC performance expectations. This will be used to keep track of WebRTC's performance tests. These used to be in the internal build bot code for WebRTC, but we need to move them due to a recent chrome infra change. We can't put them in the regular tools/perf_expectations yet since we are not done migrating to chrome infra. This is expected to be temporary. BUG= NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192820

Patch Set 1 #

Patch Set 2 : Fixed json and file name #

Patch Set 3 : Moved expectations, added README #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
A tools/webrtc_perf_expectations/README View 1 2 1 chunk +13 lines, -0 lines 1 comment Download
A tools/webrtc_perf_expectations/perf_expectations.json View 1 2 1 chunk +8 lines, -0 lines 1 comment Download
A tools/webrtc_perf_expectations/webrtc_perf_expectations.cfg View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
phoglund_chromium
I put the webrtc perfomance expectations in chrome/browser/media as it felt as a reasonable "home" ...
7 years, 8 months ago (2013-04-08 10:52:20 UTC) #1
kjellander_chromium
I suggest putting these files in a new folder instead: tools/webrtc_perf_expectations Mention in the description ...
7 years, 8 months ago (2013-04-08 14:07:00 UTC) #2
phoglund_chromium
PTAL (xians no longer need to review).
7 years, 8 months ago (2013-04-08 14:15:18 UTC) #3
kjellander_chromium
lgtm
7 years, 8 months ago (2013-04-08 14:21:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/13773008/7001
7 years, 8 months ago (2013-04-08 14:22:12 UTC) #5
commit-bot: I haz the power
Change committed as 192820
7 years, 8 months ago (2013-04-08 14:22:25 UTC) #6
no longer working on chromium
7 years, 8 months ago (2013-04-08 14:33:26 UTC) #7
Message was sent while issue was closed.
lgtm, % nits

https://codereview.chromium.org/13773008/diff/7001/tools/webrtc_perf_expectat...
File tools/webrtc_perf_expectations/README (right):

https://codereview.chromium.org/13773008/diff/7001/tools/webrtc_perf_expectat...
tools/webrtc_perf_expectations/README:2: Overview
should we follow some existing README pattern, like src/testing/gmock/README?

https://codereview.chromium.org/13773008/diff/7001/tools/webrtc_perf_expectat...
File tools/webrtc_perf_expectations/perf_expectations.json (right):

https://codereview.chromium.org/13773008/diff/7001/tools/webrtc_perf_expectat...
tools/webrtc_perf_expectations/perf_expectations.json:5:
"linux-chrome-pure/webrtc_pyauto/cpu/jsep01_call": {"reva": 177905, "revb":
178004, "type": "absolute", "improve": 21.185, "regress": 39.375, "sha1":
"5403a58a"},
nit, alphabet order

Powered by Google App Engine
This is Rietveld 408576698