Issue 137723002: Split words on text direction boundaries when computing preffered width

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137723002: Split words on text direction boundaries when computing preffered width (Closed)

Created:
6 years, 11 months ago by eae

Modified:
6 years, 11 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Split words on text direction boundaries when computing preffered width Change RenderText::computePreferredLogicalWidths to split "words" (i.e. strings without spaces) at text direction boundaries to ensure accurate measurements as text direction can effect text metrics. BUG=333004 R=leviw@chromium.org TEST=fast/text/international/inline-block-with-mixed-direction-words.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165125

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Patch for landing #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
A	LayoutTests/fast/text/international/inline-block-with-mixed-direction-words.html	View	1 2	1 chunk	+23 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/text/international/inline-block-with-mixed-direction-words-expected.html	View	1 2	1 chunk	+23 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderText.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/137723002/50001

6 years, 11 months ago (2014-01-14 18:52:06 UTC) #3

commit-bot: I haz the power

Failed to trigger a try job on win_blink_rel HTTP Error 400: Bad Request

6 years, 11 months ago (2014-01-14 21:38:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/137723002/130001

6 years, 11 months ago (2014-01-14 21:38:14 UTC) #5

Message was sent while issue was closed.

Change committed as 165125

Expand Messages | Collapse Messages