Add page load abort metrics to PageLoadMetrics system

components/page_load_metrics/browser/metrics_web_contents_observer.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_WEB_CONTENTS_OBSERVER_H_
 #define COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_WEB_CONTENTS_OBSERVER_H_
 
 #include "base/containers/scoped_ptr_map.h"
 #include "base/macros.h"
 #include "base/time/time.h"
 #include "components/page_load_metrics/common/page_load_timing.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_contents_user_data.h"
+#include "net/base/net_errors.h"
 
 namespace content {
 class NavigationHandle;
 class RenderFrameHost;
 }  // namespace content
 
 namespace IPC {
 class Message;
 }  // namespace IPC
 
 namespace page_load_metrics {
 
+// If you add or remove elements from this enum, make sure you update the enum

[Alexei Svitkine (slow), 2015/10/02 14:57:14]

Nit: Please rephrase this, as current comment implies it's safe to remove
elements from the enum, whereas in reality this shouldn't be done - as it would
make the enums inconsistent between versions.

+// value in histograms.xml.
+enum PageLoadEvent {
+  PAGE_LOAD_STARTED,
+
+  // A provisional load is a load before it commits, i.e. before it receives the
+  // first bytes of the response body or knows the encoding of the response
+  // body. A load failed before it was committed for any reason, e.g. from a
+  // user abort or a network timeout.
+  PAGE_LOAD_FAILED_BEFORE_COMMIT,
+
+  // A subset of PAGE_LOAD_FAILED_BEFORE_COMMIT, this counts the
+  // specific failures due to user aborts.
+  PAGE_LOAD_ABORTED_BEFORE_COMMIT,
+
+  // When a load is aborted anytime before the page's first layout, we increase
+  // these counts. This includes all failed provisional loads.
+  PAGE_LOAD_ABORTED_BEFORE_FIRST_LAYOUT,
+
+  // We increase this count if a page load successfully has a layout.
+  // Differentiate between loads that were backgrounded before first layout.
+  // Note that a load that is backgrounded, then foregrounded before first
+  // layout will still end up in the backgrounded bucket.
+  PAGE_LOAD_SUCCESSFUL_FIRST_LAYOUT_FOREGROUND,
+  PAGE_LOAD_SUCCESSFUL_FIRST_LAYOUT_BACKGROUND,
+
+  // Add values before this final count.
+  PAGE_LOAD_LAST_ENTRY
+};
+
 class PageLoadTracker {
  public:
   explicit PageLoadTracker(bool in_foreground);
   ~PageLoadTracker();
   void Commit();
   void WebContentsHidden();
 
   // Returns true if the timing was successfully updated.
   bool UpdateTiming(const PageLoadTiming& timing);
+  void RecordEvent(PageLoadEvent event);
 
  private:
   void RecordTimingHistograms();
 
   bool has_commit_;
 
   // We record separate metrics for events that occur after a background,
   // because metrics like layout/paint are delayed artificially
   // when they occur in the bacground.
   base::TimeTicks background_time_;
@@ skipping 44 matching lines @@
   base::ScopedPtrMap<content::NavigationHandle*, scoped_ptr<PageLoadTracker>>
       provisional_loads_;
   scoped_ptr<PageLoadTracker> committed_load_;
 
   DISALLOW_COPY_AND_ASSIGN(MetricsWebContentsObserver);
 };
 
 }  // namespace page_load_metrics
 
 #endif  // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_WEB_CONTENTS_OBSERVER_H_