Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1377213004: Subzero: Improve lowering sequence for "a=b*b". (Closed)

Created:
5 years, 2 months ago by Jim Stichnoth
Modified:
5 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Improve lowering sequence for "a=b*b". Originally, the lowering sequence looked like: T = b T *= b a = T Now it looks like: T = b T *= T a = T If "b" gets a register and its live range ends after this instruction, then the new lowering sequence allows its register to be reused for "T". This decreases register pressure, and removes an instruction (register move) from what could be a critical path. This optimization is actually applicable for most arithmetic operations whose source operands are identical, but mul/fmul are the only ones that seem at all likely in practice. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=ebbb5912415bf46798f064fea93863a95f32efd8

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -6 lines) Patch
M src/IceTargetLoweringX86BaseImpl.h View 5 chunks +7 lines, -6 lines 0 comments Download
A tests_lit/llvm2ice_tests/square.ll View 1 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
Small change, but appears to gain 1% here and there across spec2k.
5 years, 2 months ago (2015-10-02 21:13:30 UTC) #2
Karl
lgtm
5 years, 2 months ago (2015-10-05 21:02:43 UTC) #3
Jim Stichnoth
5 years, 2 months ago (2015-10-05 22:12:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ebbb5912415bf46798f064fea93863a95f32efd8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698