Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2799)

Unified Diff: chrome/chrome_repack_locales.gni

Issue 1377213003: [MD settings] moving settings strings to a separate grd file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removing language pak files for settings strings Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_repack_locales.gni
diff --git a/chrome/chrome_repack_locales.gni b/chrome/chrome_repack_locales.gni
index 81cd09277deb1d9a593d5451a56ee55a7a6226b5..955c5f14506ebf5ac14c45cec3226bba5ff1e802 100644
--- a/chrome/chrome_repack_locales.gni
+++ b/chrome/chrome_repack_locales.gni
@@ -31,12 +31,17 @@ template("_repack_one_locale") {
"${root_gen_dir}/components/strings/components_strings_${locale}.pak",
]
deps = [
- "//chrome/app/resources:platform_locale_settings",
"//chrome/app:generated_resources",
"//chrome/app/resources:locale_settings",
+ "//chrome/app/resources:platform_locale_settings",
"//components/strings:components_strings",
]
+ # The settings strings are not being treated as strings because they are
+ # not translated (English only), this should change in late 2015.
+ sources += [ "${root_gen_dir}/chrome/settings_strings.pak" ]
+ deps += [ "//chrome/app:settings_strings" ]
+
if (use_ash) {
sources += [ "${root_gen_dir}/ash/strings/ash_strings_${locale}.pak" ]
deps += [ "//ash/strings" ]
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | chrome/chrome_repack_resources.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698