third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp - Issue 1377203002: Move line-height property handling into CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1377203002: Move line-height property handling into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch for landing Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

index aee7e558242e183fd519f5ff135213253aa9ee25..cf3c7b1ab6cd1483ab07aa59fccbfdc44d43d8b6 100644

--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

@@ -777,9 +777,6 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import

}

break;

- case CSSPropertyLineHeight:

- parsedValue = parseLineHeight();

- break;

case CSSPropertyCounterIncrement:

if (id == CSSValueNone)

validPrimitive = true;

@@ -1413,6 +1410,7 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import

case CSSPropertyWordSpacing:

case CSSPropertyTabSize:

case CSSPropertyFontSize:

+ case CSSPropertyLineHeight:

validPrimitive = false;

break;

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »