chromeos: Stop directly downloading files to the cache directory from DriveFileSystem::GetResolvedF…

chrome/browser/chromeos/drive/drive_cache.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/drive/drive_cache.h"
 
 #include <vector>
 
 #include "base/file_util.h"
 #include "base/logging.h"
@@ skipping 563 matching lines @@
   return result.Pass();
 }
 
 DriveFileError DriveCache::StoreOnBlockingPool(
     const std::string& resource_id,
     const std::string& md5,
     const base::FilePath& source_path,
     FileOperationType file_operation_type) {
   AssertOnSequencedWorkerPool();
 
+  int64 file_size = 0;
   if (file_operation_type == FILE_OPERATION_COPY) {
-    int64 file_size;
     if (!file_util::GetFileSize(source_path, &file_size)) {
       LOG(WARNING) << "Couldn't get file size for: " << source_path.value();
       return DRIVE_FILE_ERROR_FAILED;
     }
-
-    const bool enough_space = FreeDiskSpaceOnBlockingPoolIfNeededFor(file_size);
-    if (!enough_space)
-      return DRIVE_FILE_ERROR_NO_SPACE;
   }
+  if (!FreeDiskSpaceOnBlockingPoolIfNeededFor(file_size))
+    return DRIVE_FILE_ERROR_NO_SPACE;
 
   base::FilePath symlink_path;
   CacheSubDirectoryType sub_dir_type = CACHE_TYPE_TMP;
 
   // If file was previously pinned, store it in persistent dir.
   DriveCacheEntry cache_entry;
   if (GetCacheEntryOnBlockingPool(resource_id, md5, &cache_entry)) {
     // File exists in cache.
     // If file is dirty or mounted, return error.
     if (cache_entry.is_dirty() || cache_entry.is_mounted()) {
@@ skipping 597 matching lines @@
   return success;
 }
 
 // static
 DriveCache::CacheSubDirectoryType DriveCache::GetSubDirectoryType(
     const DriveCacheEntry& cache_entry) {
   return cache_entry.is_persistent() ? CACHE_TYPE_PERSISTENT : CACHE_TYPE_TMP;
 }
 
 }  // namespace drive