Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: third_party/WebKit/Source/core/html/HTMLAnchorElement.h

Issue 1377163002: Use DOMSettableTokenList for {HTMLAnchorElement, HTMLAreaElement}.ping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: warning C4275 Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLAnchorElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLAnchorElement.h b/third_party/WebKit/Source/core/html/HTMLAnchorElement.h
index 17161225c936aa4128728b58dca51fd4aa26b120..8ad8e8d8c22fd3d5541c10e3ab948e22e4d256e7 100644
--- a/third_party/WebKit/Source/core/html/HTMLAnchorElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLAnchorElement.h
@@ -26,6 +26,7 @@
#include "core/CoreExport.h"
#include "core/HTMLNames.h"
+#include "core/dom/DOMSettableTokenList.h"
#include "core/dom/DOMURLUtils.h"
#include "core/dom/Document.h"
#include "core/html/HTMLElement.h"
@@ -56,9 +57,14 @@ enum {
// RelationUp = 0x00020000,
};
-class CORE_EXPORT HTMLAnchorElement : public HTMLElement, public DOMURLUtils {
+#if COMPILER(MSVC)
+#pragma warning(disable: 4275) // Disable warning C4275
philipj_slow 2015/10/07 13:02:37 This is done very rarely in Blink. What is the war
+#endif
+
+class CORE_EXPORT HTMLAnchorElement : public HTMLElement, public DOMURLUtils, public DOMSettableTokenListObserver {
DEFINE_WRAPPERTYPEINFO();
public:
+ DECLARE_VIRTUAL_TRACE();
static PassRefPtrWillBeRawPtr<HTMLAnchorElement> create(Document&);
~HTMLAnchorElement() override;
@@ -86,6 +92,8 @@ public:
void sendPings(const KURL& destinationURL) const;
+ DOMSettableTokenList* ping();
+
protected:
HTMLAnchorElement(const QualifiedName&, Document&);
@@ -111,9 +119,13 @@ private:
InsertionNotificationRequest insertedInto(ContainerNode*) override;
void handleClick(Event*);
+ // DOMSettableTokenListObserver
+ void valueChanged() override;
+
uint32_t m_linkRelations;
mutable LinkHash m_cachedVisitedLinkHash;
bool m_wasFocusedByMouse;
+ RefPtrWillBeMember<DOMSettableTokenList> m_ping;
};
inline LinkHash HTMLAnchorElement::visitedLinkHash() const

Powered by Google App Engine
This is Rietveld 408576698