Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: snapshot/win/memory_map_region_snapshot_win.h

Issue 1377133006: Mostly-boilerplate to add MemoryMapSnapshot (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@memory-info-to-misc
Patch Set: fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/test/test_process_snapshot.cc ('k') | snapshot/win/memory_map_region_snapshot_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/win/memory_map_region_snapshot_win.h
diff --git a/snapshot/mac/mach_o_image_annotations_reader_test_module_crashy_initializer.cc b/snapshot/win/memory_map_region_snapshot_win.h
similarity index 52%
copy from snapshot/mac/mach_o_image_annotations_reader_test_module_crashy_initializer.cc
copy to snapshot/win/memory_map_region_snapshot_win.h
index 2ba9bee043af4a606c8d6c90bb8a2b73b5867edb..725c12565e941492d1ecd2f5a9568df1537667d6 100644
--- a/snapshot/mac/mach_o_image_annotations_reader_test_module_crashy_initializer.cc
+++ b/snapshot/win/memory_map_region_snapshot_win.h
@@ -12,20 +12,26 @@
// See the License for the specific language governing permissions and
// limitations under the License.
+#ifndef CRASHPAD_SNAPSHOT_WIN_MEMORY_MAP_REGION_SNAPSHOT_WIN_H_
+#define CRASHPAD_SNAPSHOT_WIN_MEMORY_MAP_REGION_SNAPSHOT_WIN_H_
+
+#include "snapshot/memory_map_region_snapshot.h"
+
namespace crashpad {
-namespace test {
-namespace {
+namespace internal {
-class CrashyClass {
+class MemoryMapRegionSnapshotWin : public MemoryMapRegionSnapshot {
public:
- CrashyClass() {
- __builtin_trap();
- }
-};
+ explicit MemoryMapRegionSnapshotWin(const MEMORY_BASIC_INFORMATION64& mbi);
+ ~MemoryMapRegionSnapshotWin() override;
-// __attribute__((used)) keeps the dead code stripper away.
-__attribute__((used)) CrashyClass g_crashy_object;
+ virtual const MINIDUMP_MEMORY_INFO& AsMinidumpMemoryInfo() const override;
-} // namespace
-} // namespace test
+ private:
+ MINIDUMP_MEMORY_INFO memory_info_;
+};
+
+} // namespace internal
} // namespace crashpad
+
+#endif // CRASHPAD_SNAPSHOT_WIN_MEMORY_MAP_REGION_SNAPSHOT_WIN_H_
« no previous file with comments | « snapshot/test/test_process_snapshot.cc ('k') | snapshot/win/memory_map_region_snapshot_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698