snapshot/minidump/process_snapshot_minidump.h - Issue 1377133006: Mostly-boilerplate to add MemoryMapSnapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/minidump/process_snapshot_minidump.h

Issue 1377133006: Mostly-boilerplate to add MemoryMapSnapshot (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@memory-info-to-misc

Patch Set: fixes Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/minidump/process_snapshot_minidump.h

diff --git a/snapshot/minidump/process_snapshot_minidump.h b/snapshot/minidump/process_snapshot_minidump.h

index 6de64c962901b8f1d70db57d3db5b822d3502f85..c02fcc9b96f3496b3ace2a3e0e39bc70f9bbc689 100644

--- a/snapshot/minidump/process_snapshot_minidump.h

+++ b/snapshot/minidump/process_snapshot_minidump.h

@@ -69,6 +69,7 @@ class ProcessSnapshotMinidump final : public ProcessSnapshot {

std::vector<const ThreadSnapshot*> Threads() const override;

std::vector<const ModuleSnapshot*> Modules() const override;

const ExceptionSnapshot* Exception() const override;

+ std::vector<const MemoryMapRegionSnapshot*> MemoryMap() const override;

std::vector<const MemorySnapshot*> ExtraMemory() const override;

private:

« no previous file with comments | « snapshot/memory_map_region_snapshot.h ('k') | snapshot/minidump/process_snapshot_minidump.cc » ('j') | no next file with comments »