Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: snapshot/memory_map_region_snapshot.h

Issue 1377133006: Mostly-boilerplate to add MemoryMapSnapshot (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@memory-info-to-misc
Patch Set: 80col Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: snapshot/memory_map_region_snapshot.h
diff --git a/test/paths_win.cc b/snapshot/memory_map_region_snapshot.h
similarity index 56%
copy from test/paths_win.cc
copy to snapshot/memory_map_region_snapshot.h
index 95d0264ed82ab36cf0e541315528d44585f4bbb8..f30cbce3c129554aeeedc7506563f06c7bbdd114 100644
--- a/test/paths_win.cc
+++ b/snapshot/memory_map_region_snapshot.h
@@ -12,19 +12,24 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#include "test/paths.h"
+#ifndef CRASHPAD_SNAPSHOT_MEMORY_MAP_REGION_SNAPSHOT_H_
+#define CRASHPAD_SNAPSHOT_MEMORY_MAP_REGION_SNAPSHOT_H_
#include <windows.h>
+#include <dbghelp.h>
namespace crashpad {
-namespace test {
-// static
-base::FilePath Paths::Executable() {
- wchar_t executable_path[_MAX_PATH];
- GetModuleFileName(nullptr, executable_path, sizeof(executable_path));
- return base::FilePath(executable_path);
-}
+//! \brief An abstract interface to a snapshot representing a region of the
+//! memory map present in the snapshot process.
+class MemoryMapRegionSnapshot {
+ public:
+ virtual ~MemoryMapRegionSnapshot() {}
+
+ //! \brief Gets a MINIDUMP_MEMORY_INFO representing the region.
+ virtual MINIDUMP_MEMORY_INFO AsMinidumpMemoryInfo() const = 0;
Mark Mentovai 2015/10/12 14:35:54 This may need to to change to something that can e
scottmg 2015/10/13 19:33:31 Done.
+};
-} // namespace test
} // namespace crashpad
+
+#endif // CRASHPAD_SNAPSHOT_MEMORY_MAP_REGION_SNAPSHOT_H_

Powered by Google App Engine
This is Rietveld 408576698