Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: snapshot/minidump/process_snapshot_minidump.cc

Issue 1377133006: Mostly-boilerplate to add MemoryMapSnapshot (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@memory-info-to-misc
Patch Set: fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « snapshot/minidump/process_snapshot_minidump.h ('k') | snapshot/process_snapshot.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 } 170 }
171 return modules; 171 return modules;
172 } 172 }
173 173
174 const ExceptionSnapshot* ProcessSnapshotMinidump::Exception() const { 174 const ExceptionSnapshot* ProcessSnapshotMinidump::Exception() const {
175 INITIALIZATION_STATE_DCHECK_VALID(initialized_); 175 INITIALIZATION_STATE_DCHECK_VALID(initialized_);
176 NOTREACHED(); // https://code.google.com/p/crashpad/issues/detail?id=10 176 NOTREACHED(); // https://code.google.com/p/crashpad/issues/detail?id=10
177 return nullptr; 177 return nullptr;
178 } 178 }
179 179
180 std::vector<const MemoryMapRegionSnapshot*> ProcessSnapshotMinidump::MemoryMap()
181 const {
182 INITIALIZATION_STATE_DCHECK_VALID(initialized_);
183 NOTREACHED(); // https://code.google.com/p/crashpad/issues/detail?id=10
184 return std::vector<const MemoryMapRegionSnapshot*>();
185 }
186
180 std::vector<const MemorySnapshot*> ProcessSnapshotMinidump::ExtraMemory() 187 std::vector<const MemorySnapshot*> ProcessSnapshotMinidump::ExtraMemory()
181 const { 188 const {
182 INITIALIZATION_STATE_DCHECK_VALID(initialized_); 189 INITIALIZATION_STATE_DCHECK_VALID(initialized_);
183 NOTREACHED(); // https://code.google.com/p/crashpad/issues/detail?id=10 190 NOTREACHED(); // https://code.google.com/p/crashpad/issues/detail?id=10
184 return std::vector<const MemorySnapshot*>(); 191 return std::vector<const MemorySnapshot*>();
185 } 192 }
186 193
187 bool ProcessSnapshotMinidump::InitializeCrashpadInfo() { 194 bool ProcessSnapshotMinidump::InitializeCrashpadInfo() {
188 const auto& stream_it = stream_map_.find(kMinidumpStreamTypeCrashpadInfo); 195 const auto& stream_it = stream_map_.find(kMinidumpStreamTypeCrashpadInfo);
189 if (stream_it == stream_map_.end()) { 196 if (stream_it == stream_map_.end()) {
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 << "duplicate module_crashpad_info_list minidump_module_list_index " 331 << "duplicate module_crashpad_info_list minidump_module_list_index "
325 << minidump_link.minidump_module_list_index; 332 << minidump_link.minidump_module_list_index;
326 return false; 333 return false;
327 } 334 }
328 } 335 }
329 336
330 return true; 337 return true;
331 } 338 }
332 339
333 } // namespace crashpad 340 } // namespace crashpad
OLDNEW
« no previous file with comments | « snapshot/minidump/process_snapshot_minidump.h ('k') | snapshot/process_snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698