Mostly-boilerplate to add MemoryMapSnapshot

compat/non_win/dbghelp.h

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 119 matching lines @@
   //!
   //! \note This field is interpreted as a byte count, not a count of UTF-16
   //!     code units or Unicode code points.
   uint32_t Length;
 
   //! \brief The string, encoded in UTF-16, and terminated with a UTF-16 `NUL`
   //!     code unit (two `NUL` bytes).
   base::char16 Buffer[0];
 };
 
+//! \brief Describes a region of memory.
+struct __attribute__((packed, aligned(4))) MINIDUMP_MEMORY_INFO {

[Mark Mentovai, 2015/10/06 20:44:49]

Everything in here is ordered the same as in dbghelp.h (or now
minidumpapiset.h), so MINIDUMP_MEMORY_INFO should follow MINIDUMP_MISC_INFO_4.

[scottmg, 2015/10/07 21:45:09]

Done.

+  //! \brief The base address of the region of pages.
+  uint64_t BaseAddress;
+
+  //! \brief The base address of a range of pages in this region. The page is
+  //!     contained within this memory region.
+  uint64_t AllocationBase;
+
+  //! \brief The memory protection when the region was initially allocated. This
+  //!     member can be one of the memory protection options (such as
+  //!     `PAGE_EXECUTE`, `PAGE_NOACCESS`, etc.), along with `PAGE_GUARD` or
+  //!     `PAGE_NOCACHE`, as needed.
+  uint32_t AllocationProtect;
+
+  //! \brief To align the next field.
+  uint32_t __alignment1;
+
+  //! \brief The size of the region beginning at the base address in which all
+  //!     pages have identical attributes, in bytes.
+  uint64_t RegionSize;
+
+  //! \brief The state of the pages in the region. This can be one of
+  //! `MEM_COMMIT`, `MEM_FREE`, or `MEM_RESERVE`.
+  uint32_t State;
+
+  //! \brief The access protection of the pages in the region. This member is
+  //!     one of the values listed for the AllocationProtect member.

[Mark Mentovai, 2015/10/06 20:44:49]

#AllocationProtect for proper linking in the generated documentation.

[scottmg, 2015/10/07 21:45:09]

Done.

+  uint32_t Protect;
+
+  //! \brief The type of pages in the region. This can be one of `MEM_IMAGE`,
+  //!     `MEM_MAPPED`, or `MEM_PRIVATE`.
+  uint32_t Type;
+
+  //! \brief To align the next MINIDUMP_MEMORY_INFO in an array.
+  uint32_t __alignment2;
+};
+
 //! \brief Minidump stream type values for MINIDUMP_DIRECTORY::StreamType. Each
 //!     stream structure has a corresponding stream type value to identify it.
 //!
 //! \sa crashpad::MinidumpStreamType
 enum MINIDUMP_STREAM_TYPE {
   //! \brief The stream type for MINIDUMP_THREAD_LIST.
   ThreadListStream = 3,
 
   //! \brief The stream type for MINIDUMP_MODULE_LIST.
   ModuleListStream = 4,
@@ skipping 677 matching lines @@
   //!     module that produced a minidump file.
   //!
   //! This string is UTF-16-encoded and terminated by a UTF-16 `NUL` code unit.
   //!
   //! On Windows 8.1 (NT 6.3), this may be “dbghelp.i386,6.3.9600.16520” or
   //! “dbghelp.amd64,6.3.9600.16520” depending on CPU architecture.
   base::char16 DbgBldStr[40];
 };
 
 //! \brief The latest known version of the MINIDUMP_MISC_INFO structure.
 typedef MINIDUMP_MISC_INFO_4 MINIDUMP_MISC_INFO_N;

[Mark Mentovai, 2015/10/06 20:44:49]

Hey, whaddya know, Windows 10 adds MINIDUMP_MISC_INFO_5!

    XSTATE_CONFIG_FEATURE_MSC_INFO XStateData;    
    ULONG32 ProcessCookie;

The XStateData isn’t interesting until we have AVX support (and even then,
probably not until we have AVX-512). That’s
https://code.google.com/p/crashpad/issues/detail?id=58.

I don’t know what ProcessCookie is. My two guesses are the stack canary value
and the EncodePointer() key.

No need to do anything here yet, I just thought you’d be interested if you
haven’t seen it yet.

[scottmg, 2015/10/07 21:45:09]

Ah, I hadn't. It'd be nice if they documented something past _2. :/

 
 //! \brief Minidump file type values for MINIDUMP_HEADER::Flags. These bits
 //!     describe the types of data carried within a minidump file.
 enum MINIDUMP_TYPE {
   //! \brief A minidump file without any additional data.
   //!
   //! This type of minidump file contains:
   //!  - A MINIDUMP_SYSTEM_INFO stream.
   //!  - A MINIDUMP_MISC_INFO, MINIDUMP_MISC_INFO_2, MINIDUMP_MISC_INFO_3, or
   //!    MINIDUMP_MISC_INFO_4 stream, depending on which fields are present.
   //!  - A MINIDUMP_THREAD_LIST stream. All threads are present, along with a
   //!    snapshot of each thread’s stack memory sufficient to obtain backtraces.
   //!  - If the minidump file was generated as a result of an exception, a
   //!    MINIDUMP_EXCEPTION_STREAM describing the exception.
   //!  - A MINIDUMP_MODULE_LIST stream. All loaded modules are present.
   //!  - Typically, a MINIDUMP_MEMORY_LIST stream containing duplicate pointers
   //!    to the stack memory regions also referenced by the MINIDUMP_THREAD_LIST
   //!    stream. This type of minidump file also includes a
   //!    MINIDUMP_MEMORY_DESCRIPTOR containing the 256 bytes centered around
   //!    the exception address or the instruction pointer.
   MiniDumpNormal = 0x00000000,
 };
 
 #endif  // CRASHPAD_COMPAT_NON_WIN_DBGHELP_H_