Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 137713007: Check for GN args using the union of all rather than individually. (Closed)

Created:
6 years, 10 months ago by brettw
Modified:
6 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Check for GN args using the union of all rather than individually. Previously we would check for unused args on a per-build basis. In the GYP build we run the build multiple times, and not all args might be declared in all types of builds. For example, clang args would only be relevant for clang builds, which might only be in the host GYP build. Makes unused args errors nonfatal. This was coming up a lot in benign cases. It's important to notify people about unused arguments, but it's not critical to block progress on this problem. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251080

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -19 lines) Patch
M tools/gn/args.h View 2 chunks +14 lines, -5 lines 0 comments Download
M tools/gn/args.cc View 4 chunks +29 lines, -6 lines 0 comments Download
M tools/gn/command_args.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/command_gyp.cc View 3 chunks +41 lines, -1 line 0 comments Download
M tools/gn/setup.h View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/gn/setup.cc View 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 10 months ago (2014-02-11 21:28:35 UTC) #1
scottmg
lgtm
6 years, 10 months ago (2014-02-11 21:53:51 UTC) #2
brettw
6 years, 10 months ago (2014-02-13 18:03:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r251080 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698