runtime/vm/intermediate_language_mips.cc - Issue 1377113004: VM: Support phis with pair representations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 1377113004: VM: Support phis with pair representations. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fix ia32 mint shift right as well Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language_mips.cc

diff --git a/runtime/vm/intermediate_language_mips.cc b/runtime/vm/intermediate_language_mips.cc

index 15fc876447e14290bcace045e6ef32ca99e79471..a63ba7d99284eabb067fc7c91e1be56e17c65cf6 100644

--- a/runtime/vm/intermediate_language_mips.cc

+++ b/runtime/vm/intermediate_language_mips.cc

@@ -4931,7 +4931,13 @@ void ShiftMintOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

__ or_(out_lo, out_lo, TMP);

__ sra(out_hi, left_hi, shift);

} else {

- __ sra(out_lo, left_hi, shift - 32);

+ if (shift == 32) {

+ __ mov(out_lo, left_hi);

+ } else if (shift < 64) {

+ __ sra(out_lo, left_hi, shift - 32);

+ } else {

+ __ sra(out_lo, left_hi, 31);

+ }

__ sra(out_hi, left_hi, 31);

}

break;