runtime/vm/intermediate_language_ia32.cc - Issue 1377113004: VM: Support phis with pair representations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 1377113004: VM: Support phis with pair representations. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fix ia32 mint shift right as well Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language_ia32.cc

diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc

index e0bfb7f48534340d1b489a42a927445e74f2453b..71cc1538770ea5bae5ad518bbc29a006846e5793 100644

--- a/runtime/vm/intermediate_language_ia32.cc

+++ b/runtime/vm/intermediate_language_ia32.cc

@@ -6088,7 +6088,7 @@ void ShiftMintOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

__ movl(left_lo, left_hi); // Shift by 32.

__ sarl(left_hi, Immediate(31)); // Sign extend left hi.

if (shift > 32) {

- __ sarl(left_lo, Immediate(shift - 32));

+ __ sarl(left_lo, Immediate(shift > 63 ? 31 : shift - 32));

}

} else {

__ shrdl(left_lo, left_hi, Immediate(shift));