runtime/vm/flow_graph_builder.cc - Issue 1377113004: VM: Support phis with pair representations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 1377113004: VM: Support phis with pair representations. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fix ia32 mint shift right as well Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_builder.cc

diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc

index 9bbd9e083764eb564c0cd36bf693eccea4db1e20..f221e19c52f0524387e91f647c878f66bab67ae7 100644

--- a/runtime/vm/flow_graph_builder.cc

+++ b/runtime/vm/flow_graph_builder.cc

@@ -489,7 +489,7 @@ Definition* InlineExitCollector::JoinReturns(BlockEntryInstr** exit_block,

if (call_->HasUses()) {

// Add a phi of the return values.

PhiInstr* phi = new(Z) PhiInstr(join, num_exits);

- phi->set_ssa_temp_index(caller_graph_->alloc_ssa_temp_index());

+ caller_graph_->AllocateSSAIndexes(phi);

phi->mark_alive();

for (intptr_t i = 0; i < num_exits; ++i) {

ReturnAt(i)->RemoveEnvironment();