runtime/vm/flow_graph.cc - Issue 1377113004: VM: Support phis with pair representations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph.cc

Issue 1377113004: VM: Support phis with pair representations. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fix ia32 mint shift right as well Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph.cc

diff --git a/runtime/vm/flow_graph.cc b/runtime/vm/flow_graph.cc

index b6984ac3142a6c14a35107df36b6e658d3431477..a4753f25f006c7f37636714953b42b301d59e5ad 100644

--- a/runtime/vm/flow_graph.cc

+++ b/runtime/vm/flow_graph.cc

@@ -921,7 +921,7 @@ void FlowGraph::RenameRecursive(BlockEntryInstr* block_entry,

PhiInstr* phi = (*join->phis())[i];

if (phi != NULL) {

(*env)[i] = phi;

- phi->set_ssa_temp_index(alloc_ssa_temp_index()); // New SSA temp.

+ AllocateSSAIndexes(phi); // New SSA temp.

if (block_entry->InsideTryBlock() && !phi->is_alive()) {

// This is a safe approximation. Inside try{} all locals are

// used at every call implicitly, so we mark all phis as live

« no previous file with comments | « no previous file | runtime/vm/flow_graph_allocator.cc » ('j') | runtime/vm/flow_graph_optimizer.cc » ('J')