runtime/vm/il_printer.cc - Issue 1377113004: VM: Support phis with pair representations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/il_printer.cc

Issue 1377113004: VM: Support phis with pair representations. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/il_printer.cc

diff --git a/runtime/vm/il_printer.cc b/runtime/vm/il_printer.cc

index c691b857ff5f7d491484e7ee71093fb5a60154c9..2decba3ce80c062922bec356d35ec5c4f21cc2a2 100644

--- a/runtime/vm/il_printer.cc

+++ b/runtime/vm/il_printer.cc

@@ -1050,7 +1050,12 @@ static const char *RepresentationToCString(Representation rep) {

void PhiInstr::PrintTo(BufferFormatter* f) const {

- f->Print("v%" Pd " <- phi(", ssa_temp_index());

+ if (HasPairRepresentation()) {

+ f->Print("(v%" Pd ", v%" Pd ") <- phi(",

+ ssa_temp_index(), ssa_temp_index() + 1);

+ } else {

+ f->Print("v%" Pd " <- phi(", ssa_temp_index());

+ }

for (intptr_t i = 0; i < inputs_.length(); ++i) {

if (inputs_[i] != NULL) inputs_[i]->PrintTo(f);

if (i < inputs_.length() - 1) f->Print(", ");