Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: dashboard/dashboard/static/group_report.html

Issue 1377113003: Show ref series on group_report charts if available. (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dashboard/dashboard/static/group_report_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/static/group_report.html
diff --git a/dashboard/dashboard/static/group_report.html b/dashboard/dashboard/static/group_report.html
index 7dc119737fde95aeb625c555521f04996577bf23..2294ea8ad8ae1267531a8e418fce03384d8fe05a 100644
--- a/dashboard/dashboard/static/group_report.html
+++ b/dashboard/dashboard/static/group_report.html
@@ -57,12 +57,25 @@ var group_report = (function() {
if (subtestsEntry && subtestsEntry['sub_tests'] &&
Object.keys(subtestsEntry['sub_tests']).length == 0) {
testPath = testPath.split('/').slice(0, -1).join('/');
+ subtestsEntry = getSubtestsEntry(testPath);
+ }
+
+ // Get a list of selected traces. This should include the series that the
+ // alert was on, as well as any related reference build result series.
+ var selectedTraces = [traceName];
+ if (subtestsEntry && subtestsEntry['sub_tests']) {
+ if ('ref' in subtestsEntry['sub_tests']) {
+ selectedTraces.push('ref');
+ }
+ if (traceName + '_ref' in subtestsEntry['sub_tests']) {
+ selectedTraces.push(traceName + '_ref');
+ }
}
// Otherwise, the test is either not found in the SUBTESTS dict, or it is
// a test with children (e.g. a summary metric). In either of these cases,
// we want to return the test path and trace found on the alert.
- return [testPath, [traceName]];
+ return [testPath, selectedTraces];
};
var getTestPath = function(alert) {
« no previous file with comments | « no previous file | dashboard/dashboard/static/group_report_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698