Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 1377103005: Restructuring of JSObject::preventExtensions. (Closed)

Created:
5 years, 2 months ago by neis
Modified:
5 years, 2 months ago
Reviewers:
rossberg, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Restructuring of JSObject::preventExtensions. Now there are two functions, one corresponding to the spec's [[PreventExtensions]] and one corresponding to Object.preventExtensions. They differ in what they return. This CL is in preparation of implementing Reflect.preventExtensions. R=rossberg BUG= Committed: https://crrev.com/09185f6e2dc0f568d57616dacbc559336defff80 Cr-Commit-Position: refs/heads/master@{#31096}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -28 lines) Patch
M src/messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/objects.cc View 1 6 chunks +45 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
neis
5 years, 2 months ago (2015-10-02 14:34:52 UTC) #1
rossberg
lgtm
5 years, 2 months ago (2015-10-05 10:31:13 UTC) #2
neis
Toon, can you please check if the UNREACHABLE() in src/objects.c:5976 is okay? Thanks.
5 years, 2 months ago (2015-10-05 10:54:05 UTC) #4
Toon Verwaest
That unreachable is fine, but I'd still like to keep the return false afterwards. UNREACHABLE ...
5 years, 2 months ago (2015-10-05 11:04:03 UTC) #5
neis
On 2015/10/05 11:04:03, Toon Verwaest wrote: > That unreachable is fine, but I'd still like ...
5 years, 2 months ago (2015-10-05 11:30:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377103005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377103005/20001
5 years, 2 months ago (2015-10-05 11:32:05 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-05 12:08:49 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 12:09:04 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09185f6e2dc0f568d57616dacbc559336defff80
Cr-Commit-Position: refs/heads/master@{#31096}

Powered by Google App Engine
This is Rietveld 408576698