Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1377103004: Revert of Fix OSK to show when physical keyboard is detached on KK (Closed)

Created:
5 years, 2 months ago by aelias_OOO_until_Jul13
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix OSK to show when physical keyboard is detached on KK (patchset #3 id:40001 of https://codereview.chromium.org/1322793002/ ) Reason for revert: Causes http://crbug.com/534666, and the real fix https://codereview.chromium.org/1362603002 seems like it probably won't land before 47 branch point. Revert this for now to make 47 match 46. Original issue's description: > Fix OSK to show when physical keyboard is detached on KK > > On KK, the same object is passed and we do not detect keyboard > change correctly. > > BUG=500662 > > Committed: https://crrev.com/85255cdcd8787a564e117ebd4991ce1975659b69 > Cr-Commit-Position: refs/heads/master@{#346810} TBR=jdduke@chromium.org,yfriedman@chromium.org,changwan@chromium.org NOTRY=true BUG=500662, 534666 Committed: https://crrev.com/74beb97572b4b2cd1642a7e55098c82729e7204c Cr-Commit-Position: refs/heads/master@{#351913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -78 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +2 lines, -4 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 3 chunks +0 lines, -57 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java View 3 chunks +2 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
aelias_OOO_until_Jul13
Created Revert of Fix OSK to show when physical keyboard is detached on KK
5 years, 2 months ago (2015-10-01 22:31:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377103004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377103004/1
5 years, 2 months ago (2015-10-01 22:33:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/48467)
5 years, 2 months ago (2015-10-01 22:42:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377103004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377103004/1
5 years, 2 months ago (2015-10-01 22:58:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 23:04:53 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 23:05:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74beb97572b4b2cd1642a7e55098c82729e7204c
Cr-Commit-Position: refs/heads/master@{#351913}

Powered by Google App Engine
This is Rietveld 408576698