Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 13771008: Initial redesign of the Files.app's main window. (Closed)

Created:
7 years, 8 months ago by mtomasz
Modified:
7 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, rginda+watch_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Initial redesign of the Files.app's main window. This patch removes the window decoration, changes basic styles including the file list, the list's header and the sidebar. Along the way simplifies styles for the file list. TEST=Not in production yet. Run with --file-manager-new-ui flag. BUG=226912 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192821

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Patch Set 3 : Added the forgotten file. #

Patch Set 4 : Updated. #

Patch Set 5 : Rebased. #

Patch Set 6 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -34 lines) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/css/file_manager.css View 1 29 chunks +177 lines, -26 lines 0 comments Download
M chrome/browser/resources/file_manager/js/background.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/sidebar.js View 1 chunk +9 lines, -0 lines 0 comments Download
A + chrome/browser/resources/file_manager/main_new_ui.html View 1 2 3 3 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/resources/file_manager/manifest_new_ui.json View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
mtomasz
@yoshiki: PTAL. Thanks.
7 years, 8 months ago (2013-04-08 08:29:48 UTC) #1
yoshiki
main_new_ui.html is not included. Is it in a separate patch?
7 years, 8 months ago (2013-04-08 08:46:59 UTC) #2
mtomasz
On 2013/04/08 08:46:59, yoshiki wrote: > main_new_ui.html is not included. Is it in a separate ...
7 years, 8 months ago (2013-04-08 08:56:57 UTC) #3
yoshiki
lgtm
7 years, 8 months ago (2013-04-08 09:04:30 UTC) #4
mtomasz
On 2013/04/08 09:04:30, yoshiki wrote: > lgtm Thanks!
7 years, 8 months ago (2013-04-08 09:05:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/13771008/8
7 years, 8 months ago (2013-04-08 09:05:20 UTC) #6
commit-bot: I haz the power
Presubmit check for 13771008-8 failed and returned exit status 1. INFO:root:Found 7 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-08 09:05:28 UTC) #7
mtomasz
@jochen: PTAL at the trivial change in chrome/browser/resources/component_extension_resources.grd . Thanks.
7 years, 8 months ago (2013-04-08 09:08:10 UTC) #8
jochen (gone - plz use gerrit)
lgtm
7 years, 8 months ago (2013-04-08 09:16:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/13771008/8
7 years, 8 months ago (2013-04-08 09:18:51 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 09:27:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/13771008/8
7 years, 8 months ago (2013-04-08 10:35:27 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 10:39:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/13771008/2008
7 years, 8 months ago (2013-04-08 11:43:07 UTC) #14
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 11:51:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/13771008/2008
7 years, 8 months ago (2013-04-08 12:31:55 UTC) #16
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 12:36:09 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/13771008/2008
7 years, 8 months ago (2013-04-08 13:15:27 UTC) #18
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 13:19:39 UTC) #19
mtomasz
7 years, 8 months ago (2013-04-08 14:30:05 UTC) #20
Message was sent while issue was closed.
Committed patchset #6 manually as r192821 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698