Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1377063004: Use more const, more RefPtrs while iterating the SVG shadow tree. (Closed)

Created:
5 years, 2 months ago by dominicc (has gone to gerrit)
Modified:
5 years, 1 month ago
Reviewers:
fs, kouhei (in TOK)
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use more const, more RefPtrs while iterating the SVG shadow tree. "Weak" iteration with raw pointers can cause bugs such as Issue 225403 if the tree is modified during iteration. This makes SVGUseElement use RefPtrs when appending children, and const pointers other times, when iterating over the tree. Plus some lint fixes. BUG=225420 Committed: https://crrev.com/7d78afae216dbb4326bdfbe5c806a3801207ea77 Cr-Commit-Position: refs/heads/master@{#351974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -27 lines) Patch
M third_party/WebKit/Source/core/svg/SVGUseElement.h View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 12 chunks +26 lines, -23 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dominicc (has gone to gerrit)
PTAL
5 years, 2 months ago (2015-09-30 05:36:54 UTC) #2
fs
lgtm (I wonder why we'd allow script execution at all in these contexts though...?)
5 years, 2 months ago (2015-09-30 08:47:10 UTC) #4
kouhei (in TOK)
lgtm
5 years, 2 months ago (2015-09-30 09:13:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377063004/1
5 years, 2 months ago (2015-10-02 05:56:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 08:18:23 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 08:19:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d78afae216dbb4326bdfbe5c806a3801207ea77
Cr-Commit-Position: refs/heads/master@{#351974}

Powered by Google App Engine
This is Rietveld 408576698