Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: cc/trees/proxy_impl.h

Issue 1377063003: Split ThreadProxy methods to ProxyMain and ProxyImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Keep ProxyMain and ProxyImpl methods private. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/proxy_common.cc ('k') | cc/trees/proxy_main.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/proxy_impl.h
diff --git a/cc/trees/proxy_impl.h b/cc/trees/proxy_impl.h
index 10f351e8da004ced7173a90c6a79e85a9d7c13ef..8acbb97377e108ce58d5849b55c47ca131d35709 100644
--- a/cc/trees/proxy_impl.h
+++ b/cc/trees/proxy_impl.h
@@ -7,10 +7,13 @@
#include "base/memory/weak_ptr.h"
#include "cc/base/cc_export.h"
+#include "cc/base/completion_event.h"
#include "cc/input/top_controls_state.h"
+#include "cc/output/output_surface.h"
+#include "cc/scheduler/commit_earlyout_reason.h"
+#include "cc/trees/proxy_common.h"
namespace cc {
-
// TODO(khushalsagar): The impl side of ThreadProxy. It is currently defined as
// an interface with the implementation provided by ThreadProxy and will be
// made an independent class.
@@ -18,12 +21,29 @@ namespace cc {
// variables from ThreadProxy.
// See crbug/527200
class CC_EXPORT ProxyImpl {
- public:
+ private:
+ friend class ThreadedChannel;
+
// Callback for impl side commands received from the channel.
virtual void SetThrottleFrameProductionOnImpl(bool throttle) = 0;
virtual void UpdateTopControlsStateOnImpl(TopControlsState constraints,
TopControlsState current,
bool animate) = 0;
+ virtual void InitializeOutputSurfaceOnImpl(OutputSurface* output_surface) = 0;
+ virtual void MainThreadHasStoppedFlingingOnImpl() = 0;
+ virtual void SetInputThrottledUntilCommitOnImpl(bool is_throttled) = 0;
+ virtual void SetDeferCommitsOnImpl(bool defer_commits) const = 0;
+ virtual void SetNeedsRedrawOnImpl(const gfx::Rect& damage_rect) = 0;
+ virtual void SetNeedsCommitOnImpl() = 0;
+ virtual void BeginMainFrameAbortedOnImpl(CommitEarlyOutReason reason) = 0;
+ virtual void FinishAllRenderingOnImpl(CompletionEvent* completion) = 0;
+ virtual void SetVisibleOnImpl(CompletionEvent* completion, bool visible) = 0;
+ virtual void ReleaseOutputSurfaceOnImpl(CompletionEvent* completion) = 0;
+ virtual void FinishGLOnImpl(CompletionEvent* completion) = 0;
+ virtual void MainFrameWillHappenOnImplForTesting(
+ CompletionEvent* completion,
+ bool* main_frame_will_happen) = 0;
+ virtual void StartCommitOnImpl(CompletionEvent* completion) = 0;
// TODO(khushalsagar): Rename as GetWeakPtr() once ThreadProxy is split.
virtual base::WeakPtr<ProxyImpl> GetImplWeakPtr() = 0;
« no previous file with comments | « cc/trees/proxy_common.cc ('k') | cc/trees/proxy_main.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698