Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 137703014: cc: Limit software resource sizes (Closed)

Created:
6 years, 10 months ago by enne (OOO)
Modified:
6 years, 10 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org, danakj, jbauman, jamesr
Visibility:
Public.

Description

cc: Limit software resource sizes Althought the software renderer *could* support much larger sizes than the hardware renderer, there's no reason to allow them. This will create a little bit more consistency between platforms and will prevent security issues caused by gigantic allocations. BUG=337882 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250870

Patch Set 1 #

Patch Set 2 : Chunk mismatch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
cc/resources/resource_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
enne (OOO)
6 years, 10 months ago (2014-02-12 21:02:08 UTC) #1
reveman
lgtm but it looks like you might have to re-upload the patch
6 years, 10 months ago (2014-02-12 21:18:50 UTC) #2
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 10 months ago (2014-02-12 21:21:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/137703014/30001
6 years, 10 months ago (2014-02-12 21:22:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 22:57:00 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=262832
6 years, 10 months ago (2014-02-12 22:57:00 UTC) #6
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 10 months ago (2014-02-12 22:59:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/137703014/30001
6 years, 10 months ago (2014-02-12 23:01:22 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 00:45:03 UTC) #9
Message was sent while issue was closed.
Change committed as 250870

Powered by Google App Engine
This is Rietveld 408576698