Rename confusing child_id to unique_id_win

Rename confusing child_id to unique_id_win

Each BrowserAccessibility had a "child_id", which was
confusing - the word "child" and "id" both have other
meanings within accessibility. In this context, it's
really an unique ID, that's only needed on Windows,
that can be used to quickly access an object using the
get_accChild function (which is where the "child"
comes in, it should really be "descendant").

BUG=175156
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193322

[aboxhall, 2013-04-09 09:28:29]

https://codereview.chromium.org/13770015/diff/1/content/browser/accessibility...
File content/browser/accessibility/browser_accessibility_manager.cc (right):

https://codereview.chromium.org/13770015/diff/1/content/browser/accessibility...
content/browser/accessibility/browser_accessibility_manager.cc:265: void
BrowserAccessibilityManager::InitializeNode(BrowserAccessibility* node) {
This seems like a bit of a confusing name for this method, since it doesn't
actually do anything to the node (and it's called right after
node->InitializeTreeStructure). Perhaps it should be named something like
AddNodeToMap or RegisterNode?

https://codereview.chromium.org/13770015/diff/1/content/browser/accessibility...
File content/browser/accessibility/browser_accessibility_manager_win.cc (right):

https://codereview.chromium.org/13770015/diff/1/content/browser/accessibility...
content/browser/accessibility/browser_accessibility_manager_win.cc:151: LONG
child_id = node->ToBrowserAccessibilityWin()->unique_id_win();
Should this be renamed unique_id_win as well?

https://codereview.chromium.org/13770015/diff/1/content/browser/accessibility...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/13770015/diff/1/content/browser/accessibility...
content/browser/accessibility/browser_accessibility_win.cc:2941:
GetFromUniqueIdWin(child_id)->ToBrowserAccessibilityWin();
I don't think ToBrowserAccessibilityWin() is necessary here, is it?

[dmazzoni, 2013-04-09 19:44:03]

https://codereview.chromium.org/13770015/diff/1/content/browser/accessibility...
File content/browser/accessibility/browser_accessibility_manager.cc (right):

https://codereview.chromium.org/13770015/diff/1/content/browser/accessibility...
content/browser/accessibility/browser_accessibility_manager.cc:265: void
BrowserAccessibilityManager::InitializeNode(BrowserAccessibility* node) {
On 2013/04/09 09:28:29, aboxhall wrote:
> This seems like a bit of a confusing name for this method, since it doesn't
> actually do anything to the node (and it's called right after
> node->InitializeTreeStructure). Perhaps it should be named something like
> AddNodeToMap or RegisterNode?

Good idea, done.

https://codereview.chromium.org/13770015/diff/1/content/browser/accessibility...
File content/browser/accessibility/browser_accessibility_manager_win.cc (right):

https://codereview.chromium.org/13770015/diff/1/content/browser/accessibility...
content/browser/accessibility/browser_accessibility_manager_win.cc:151: LONG
child_id = node->ToBrowserAccessibilityWin()->unique_id_win();
On 2013/04/09 09:28:29, aboxhall wrote:
> Should this be renamed unique_id_win as well?

The argument to NotifyWinEvent is called "child id", so
I wanted to be clear. I added a comment.

https://codereview.chromium.org/13770015/diff/1/content/browser/accessibility...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/13770015/diff/1/content/browser/accessibility...
content/browser/accessibility/browser_accessibility_win.cc:2941:
GetFromUniqueIdWin(child_id)->ToBrowserAccessibilityWin();
On 2013/04/09 09:28:29, aboxhall wrote:
> I don't think ToBrowserAccessibilityWin() is necessary here, is it?

You're right, thanks.

[aboxhall, 2013-04-09 22:27:44]

lgtm

[commit-bot: I haz the power, 2013-04-09 22:33:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/13770015/15001

[commit-bot: I haz the power, 2013-04-10 00:49:59]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-04-10 02:18:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/13770015/15001

[commit-bot: I haz the power, 2013-04-10 04:12:15]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[dmazzoni, 2013-04-10 04:37:44]

Committed patchset #2 manually as r193322 (presubmit successful).