ui/views/widget/native_widget_aura.cc - Issue 13770008: Fix dcheck on win aura shutdown, use CloseNow to close secondary widgets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/native_widget_aura.cc

Issue 13770008: Fix dcheck on win aura shutdown, use CloseNow to close secondary widgets (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/native_widget_aura.cc

diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc

index 04af1cea6c204429f878c2efbe6f7f0103987e3b..41c69fbba9fb401994c12e4a3639ba0b33efd09a 100644

--- a/ui/views/widget/native_widget_aura.cc

+++ b/ui/views/widget/native_widget_aura.cc

@@ -903,7 +903,7 @@ BOOL CALLBACK WindowCallbackProc(HWND hwnd, LPARAM lParam) {

if (root_window) {

Widget* widget = Widget::GetWidgetForNativeView(root_window);

if (widget && widget->is_secondary_widget())

- widget->Close();

+ widget->CloseNow();

sky 2013/04/08 19:52:05 Add a comment here as to why this is OK.

}

return TRUE;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »