Issue 13770003: Translate: URL check should be done at once

Issue 13770003: Translate: URL check should be done at once (Closed)

Created:
7 years, 8 months ago by Takashi Toyoshima

Modified:
7 years, 8 months ago

Reviewers:
MAD, Vladislav Kaznacheev

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Vladislav Kaznacheev

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Translate: URL check should be done at once The URL for Chrome OS file manager extension is checked separately for now. But this must be done in IsTranslatableURL() at once. BUG=none TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192943

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add unit test #

Patch Set 3 : use extensions::kExtensionScheme #

Patch Set 4 : nits #

Patch Set 5 : rebase for dcommit #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -51 lines)			Patch
M	chrome/browser/translate/translate_manager.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/translate/translate_manager.cc	View	1 2 3 4	5 chunks	+13 lines, -16 lines	0 comments	Download
M	chrome/browser/translate/translate_manager_browsertest.cc	View	1	29 chunks	+34 lines, -33 lines	0 comments	Download
A	chrome/browser/translate/translate_manager_unittest.cc	View	1 2 3	1 chunk	+45 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

https://chromiumcodereview.appspot.com/13770003/diff/1/content/public/common/url_constants.h File content/public/common/url_constants.h (right): https://chromiumcodereview.appspot.com/13770003/diff/1/content/public/common/url_constants.h#newcode23 content/public/common/url_constants.h:23: CONTENT_EXPORT extern const char kChromeExtension[]; You are introducing a ...

7 years, 8 months ago (2013-04-08 05:45:04 UTC) #1

Takashi Toyoshima

Oh, thanks! I didn't notice that. I'll fix to use it.

7 years, 8 months ago (2013-04-08 06:10:18 UTC) #2

Takashi Toyoshima

Thanks Vladislav! Mad, Can you take a look this minor clean up change?

7 years, 8 months ago (2013-04-08 06:21:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/13770003/10003

7 years, 8 months ago (2013-04-08 17:07:45 UTC) #6

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 8 months ago (2013-04-08 17:15:00 UTC) #7

Takashi Toyoshima

7 years, 8 months ago (2013-04-08 23:25:39 UTC) #8

Message was sent while issue was closed.

Committed patchset #5 manually as r192943 (presubmit successful).

Expand Messages | Collapse Messages