Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: runtime/vm/compiler.cc

Issue 1376963002: Cleanup: we are not patching entries any longer (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_patcher.cc ('k') | runtime/vm/instructions_ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index fb575375f879ace144ea7d30af37a196e87a48fb..bc0d090477f3b9776c516e299a213161449a6b70 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -68,7 +68,6 @@ DECLARE_FLAG(bool, load_deferred_eagerly);
DECLARE_FLAG(bool, trace_failed_optimization_attempts);
DECLARE_FLAG(bool, trace_inlining_intervals);
DECLARE_FLAG(bool, trace_irregexp);
-DECLARE_FLAG(bool, trace_patching);
bool Compiler::always_optimize_ = false;
@@ -758,17 +757,7 @@ static bool CompileParsedFunctionHelper(CompilationPipeline* pipeline,
if (optimized) {
// We may not have previous code if 'always_optimize' is set.
if ((osr_id == Isolate::kNoDeoptId) && function.HasCode()) {
- CodePatcher::PatchEntry(
- Code::Handle(function.CurrentCode()),
- Code::Handle(StubCode::FixCallersTarget_entry()->code()));
- if (FLAG_trace_compiler || FLAG_trace_patching) {
- if (FLAG_trace_compiler) {
- THR_Print(" ");
- }
- THR_Print("Patch unoptimized '%s' entry point %#" Px "\n",
- function.ToFullyQualifiedCString(),
- Code::Handle(function.unoptimized_code()).EntryPoint());
- }
+ Code::Handle(function.CurrentCode()).DisableDartCode();
}
function.AttachCode(code);
« no previous file with comments | « runtime/vm/code_patcher.cc ('k') | runtime/vm/instructions_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698